facebook / openbmc

OpenBMC is an open software framework to build a complete Linux image for a Board Management Controller (BMC).

631 stars 277 forks source link

flashy: Refactor regex capture groups to use constants to reduce mistakes #146

Closed lhl2617 closed 3 years ago

lhl2617 commented 3 years ago

Summary

As title, use string constants for regex capture group names.

There is a remaining GetMTDMapFromSpecifier function still using string literals -- this function will be refactored in another diff and hence is not changed here.

Test plan

Unit tests pass (go test ./...)

facebook-github-bot commented 3 years ago

@kawmarco has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 years ago

@kawmarco merged this pull request in facebook/openbmc@5ea1f1145796e8ed7ac244bfa2937aa098603282.