facebook / openbmc

OpenBMC is an open software framework to build a complete Linux image for a Board Management Controller (BMC).

633 stars 277 forks source link

flashy: Refactor GetMtdMapFromSpecific into GetMTDInfoFromSpecifier #147

Closed lhl2617 closed 3 years ago

lhl2617 commented 3 years ago

Summary

GetMTDMapFromSpecifier would require the user to access the regex results using string keys, which is not ideal. Return instead a new MtdInfo struct that can be accessed safely.

Test plan

Unit tests pass. (go test ./...)

facebook-github-bot commented 3 years ago

@kawmarco has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 years ago

@kawmarco has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 years ago

@kawmarco merged this pull request in facebook/openbmc@05b652c061b5fbe964e12a34f6c94d0ea856856f.