facebook / openbmc

OpenBMC is an open software framework to build a complete Linux image for a Board Management Controller (BMC).

633 stars 277 forks source link

flashy: Fix staticcheck and misc. warnings #148

Closed lhl2617 closed 3 years ago

lhl2617 commented 3 years ago

Summary

As title. No functional changes. Errors fixed include those from staticcheck, obtained via staticcheck ./... | grep -vE 'ST1017|SA9004|ST1008|S1019' (filtering out annoying warnings)

Use bytes.Equal instead of bytes.Compare
Explicitly specify key when declaring structs
Remove unneeded struct names
Close fds after checking error to ensure that it is opened
Use Print instead of Printf as necessary
Remove unused vars/Use them appropriately

Test plan

Unit tests pass (go test ./...)

facebook-github-bot commented 3 years ago

@kawmarco has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.