search

facebook / openbmc

OpenBMC is an open software framework to build a complete Linux image for a Board Management Controller (BMC).
628 stars 280 forks source link

common: rest-api: Disable flake8 in CircleCI unit-test #178

Closed peterdelevoryas closed 2 years ago

peterdelevoryas commented 2 years ago

Summary: We can't mount stuff in docker containers, even as root, without --cap-add=SYS_ADMIN in container creation, which is not allowed in CircleCI.

An alternative solution is to attempt to unpack the rootfs for unit testing within an existing tmpfs, like /dev/, but /dev/ isn't big enough for our rootfs (/dev is 65MB, rootfs is 110+ MB). Alternatively, we could look at running unit tests without chroot, but that's difficult too. This problem (getting flake8 working) is kind of difficult, and I would prefer to have the unit-tests signal passing so that CircleCI in general is passing on helium, and to solve larger problems like this later.

I included some reformatting to satisfy the CircleCI linter as well.

Test Plan: Checking that the rest-api unit-test passes in CircleCI, and that flake8 still runs outside of CircleCI.

facebook-github-bot commented 2 years ago

@peterdelevoryas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@peterdelevoryas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@peterdelevoryas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@peterdelevoryas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@peterdelevoryas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

peterdelevoryas commented 2 years ago

Discarding this PR in favor of #177