search

facebook / openbmc

OpenBMC is an open software framework to build a complete Linux image for a Board Management Controller (BMC).
633 stars 277 forks source link

tests2: Add --denylist option to cit_runner.py #180

Closed peterdelevoryas closed 2 years ago

peterdelevoryas commented 2 years ago

Summary: cit_runner.py checks for the existence of the file /usr/local/bin/tests2/dummy_qemu to determine if we're in QEMU. That, in turn, determines whether we use qemu_denylist.txt to filter out tests.

This turns out to not work well in Netcastle, because even in QEMU Netcastle runs, we run cit_runner.py outside of QEMU to list tests. We need a better way to specify when to use the denylist.

I think the simplest thing is to just make it an optional argument: in CircleCI and QEMU Netcastle runs, we can specify the denylist path in the invocation, and everywhere else we can just ignore the denylist argument.

Test Plan: Watching CircleCI to make sure it doesn't break.

facebook-github-bot commented 2 years ago

@peterdelevoryas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.