search

facebook / openbmc

OpenBMC is an open software framework to build a complete Linux image for a Board Management Controller (BMC).
631 stars 277 forks source link

circleci: Make sure build dir is created for qemux86 #185

Closed peterdelevoryas closed 2 years ago

peterdelevoryas commented 2 years ago

Summary: In "Force qemux86 builds unconditionally", I didn't realize that I needed to source the build environment script (effectively initializing the build directory), because the next script download-sstate-cache depends on this build directory being setup.

I accidentally added a short-circuiting exit that skipped initializing the build directory.

This is also because I didn't properly test the previous diff!

Test Plan: Now that I'm actually submitting through Github, I'll make sure that CircleCI passes.

facebook-github-bot commented 2 years ago

@peterdelevoryas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.