search

facebook / openbmc

OpenBMC is an open software framework to build a complete Linux image for a Board Management Controller (BMC).
627 stars 280 forks source link

cit: wedge400: fix test_log_util error cit run #222

Closed Scott8440 closed 1 year ago

Scott8440 commented 1 year ago

Summary:

Description

add import pal_get_fru_id for test_log_util on wedge400

Motivation

fixe the error run for test_log_util on wedge400 error log:

ERROR: test_log_format_json (tests.wedge400.test_log_util.SMBLogUtilTest)
test log-util [FRU] --print --json and verify output
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/bin/tests2/common/base_log_util_test.py", line 32, in setUp
    self.set_fru_id()
  File "/usr/local/bin/tests2/tests/wedge400/test_log_util.py", line 34, in set_fru_id
    self.FRU_ID = pal_get_fru_id(self.FRU)
NameError: name 'pal_get_fru_id' is not defined

X-link: https://github.com/facebookexternal/openbmc.celestica/pull/1554

Test Plan: able to run wedge400.test_log_util passed as well.

root@bmc-oob:/usr/local/bin/tests2# python cit_runner.py -p montblanc -r tests.wedge400.test_log_util
test_log_clear (tests.wedge400.test_log_util.AllLogUtilTest)
test to clear SEL ... ok
test_log_format (tests.wedge400.test_log_util.AllLogUtilTest)
test log-util [FRU] --print and verify output ... ok
test_log_format_json (tests.wedge400.test_log_util.AllLogUtilTest)
test log-util [FRU] --print --json and verify output ... ok
test_log_clear (tests.wedge400.test_log_util.FAN1LogUtilTest)
test to clear SEL ... ok
test_log_format (tests.wedge400.test_log_util.FAN1LogUtilTest)
test log-util [FRU] --print and verify output ... ok
test_log_format_json (tests.wedge400.test_log_util.FAN1LogUtilTest)
test log-util [FRU] --print --json and verify output ... ok
test_log_clear (tests.wedge400.test_log_util.FAN2LogUtilTest)
test to clear SEL ... ok
test_log_format (tests.wedge400.test_log_util.FAN2LogUtilTest)
test log-util [FRU] --print and verify output ... ok
test_log_format_json (tests.wedge400.test_log_util.FAN2LogUtilTest)
test log-util [FRU] --print --json and verify output ... ok
test_log_clear (tests.wedge400.test_log_util.FAN3LogUtilTest)
test to clear SEL ... ok
test_log_format (tests.wedge400.test_log_util.FAN3LogUtilTest)
test log-util [FRU] --print and verify output ... ok
test_log_format_json (tests.wedge400.test_log_util.FAN3LogUtilTest)
test log-util [FRU] --print --json and verify output ... ok
test_log_clear (tests.wedge400.test_log_util.FAN4LogUtilTest)
test to clear SEL ... ok
test_log_format (tests.wedge400.test_log_util.FAN4LogUtilTest)
test log-util [FRU] --print and verify output ... ok
test_log_format_json (tests.wedge400.test_log_util.FAN4LogUtilTest)
test log-util [FRU] --print --json and verify output ... ok
test_log_clear (tests.wedge400.test_log_util.PEM1LogUtilTest)
test to clear SEL ... ok
test_log_format (tests.wedge400.test_log_util.PEM1LogUtilTest)
test log-util [FRU] --print and verify output ... ok
test_log_format_json (tests.wedge400.test_log_util.PEM1LogUtilTest)
test log-util [FRU] --print --json and verify output ... ok
test_log_clear (tests.wedge400.test_log_util.PEM2LogUtilTest)
test to clear SEL ... ok
test_log_format (tests.wedge400.test_log_util.PEM2LogUtilTest)
test log-util [FRU] --print and verify output ... ok
test_log_format_json (tests.wedge400.test_log_util.PEM2LogUtilTest)
test log-util [FRU] --print --json and verify output ... ok
test_log_clear (tests.wedge400.test_log_util.PSU1LogUtilTest)
test to clear SEL ... ok
test_log_format (tests.wedge400.test_log_util.PSU1LogUtilTest)
test log-util [FRU] --print and verify output ... ok
test_log_format_json (tests.wedge400.test_log_util.PSU1LogUtilTest)
test log-util [FRU] --print --json and verify output ... ok
test_log_clear (tests.wedge400.test_log_util.PSU2LogUtilTest)
test to clear SEL ... ok
test_log_format (tests.wedge400.test_log_util.PSU2LogUtilTest)
test log-util [FRU] --print and verify output ... ok
test_log_format_json (tests.wedge400.test_log_util.PSU2LogUtilTest)
test log-util [FRU] --print --json and verify output ... ok
test_log_clear (tests.wedge400.test_log_util.SCMLogUtilTest)
test to clear SEL ... ok
test_log_format (tests.wedge400.test_log_util.SCMLogUtilTest)
test log-util [FRU] --print and verify output ... ok
test_log_format_json (tests.wedge400.test_log_util.SCMLogUtilTest)
test log-util [FRU] --print --json and verify output ... ok
test_log_clear (tests.wedge400.test_log_util.SMBLogUtilTest)
test to clear SEL ... ok
test_log_format (tests.wedge400.test_log_util.SMBLogUtilTest)
test log-util [FRU] --print and verify output ... ok
test_log_format_json (tests.wedge400.test_log_util.SMBLogUtilTest)
test log-util [FRU] --print --json and verify output ... ok
test_log_clear (tests.wedge400.test_log_util.SysLogUtilTest)
test to clear SEL ... ok
test_log_format (tests.wedge400.test_log_util.SysLogUtilTest)
test log-util [FRU] --print and verify output ... ok
test_log_format_json (tests.wedge400.test_log_util.SysLogUtilTest)
test log-util [FRU] --print --json and verify output ... ok

----------------------------------------------------------------------
Ran 36 tests in 29.964s

OK
root@bmc-oob:/usr/local/bin/tests2#

Differential Revision: D46272199

Reviewed By: ssinprem

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D46272199

facebook-github-bot commented 1 year ago

This pull request has been merged in facebook/openbmc@a1deed4dad00434f377f2e2e5d8b9ed7d071d677.