facebook / openbmc

OpenBMC is an open software framework to build a complete Linux image for a Board Management Controller (BMC).
633 stars 277 forks source link

cit: fuji: resolved the test case "test_endpoint_api_sys_sensors" failure. #227

Closed Scott8440 closed 1 year ago

Scott8440 commented 1 year ago

Summary:

Description

Issue: CIT test case "test_endpoint_api_sys_sensors" failed on FUJI DC units only.

Root cause Analysis: This test case commonly checks for all PIM sensors irrespective of device configuration. Since DC device(4 or 5 PIM) have differed from AC unit(8 PIM) in PIM configuration, the test case is failed.

Fix: Test case has been altered to execute only for inserted PIMs.

Motivation

These changes will get the list of inserted PIMs and execute the rest endpoint test cases for only inserted PIMs.

X-link: https://github.com/facebookexternal/openbmc.celestica/pull/1578

Test Plan: Steps to reproduce: Execute the test case in DC Fuji devices to get the failure.

Unit test logs: In DC unit:

root@bmc-oob:/usr/local/bin/tests2# python cit_runner.py --run-test  tests.fuji.test_rest_endpoint.RestEndpointTest.test_endpoint_api_sys_sensors
test_endpoint_api_sys_sensors (tests.fuji.test_rest_endpoint.RestEndpointTest.test_endpoint_api_sys_sensors) ... ok

----------------------------------------------------------------------
Ran 1 test in 3.882s

OK

In AC unit:

root@bmc-oob:/usr/local/bin/tests2# python cit_runner.py --run-test  tests.fuji.test_rest_endpoint.RestEndpointTest.test_endpoint_api_sys_sensors
test_endpoint_api_sys_sensors (tests.fuji.test_rest_endpoint.RestEndpointTest.test_endpoint_api_sys_sensors) ... ok

----------------------------------------------------------------------
Ran 1 test in 4.089s

OK

CIT log: CIT_FUJI_DC_unit_log.txt

Differential Revision: D46795517

Reviewed By: vijay.g

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D46795517

facebook-github-bot commented 1 year ago

This pull request has been merged in facebook/openbmc@e67f9aa176605f330ac989f593f1d47849393e69.