search

facebook / openbmc

OpenBMC is an open software framework to build a complete Linux image for a Board Management Controller (BMC).
631 stars 277 forks source link

yv4: cxl-fw-update: fix incorrect cast in recvfrom function call #238

Closed maxdog988 closed 3 months ago

maxdog988 commented 4 months ago

Description

Fixe the issue by changing the declaration to 'socklen_t' for variable 'addrlen'

Motivation

Fix build break ../cci-mctp-update.cpp:77:20: error: cannot convert 'long unsigned int' to 'socklen_t' {aka 'unsigned int*'}

Test Plan

Build pass on Nuvoton NPCM8XX 64-bit BMC

facebook-github-bot commented 4 months ago

Hi @maxdog988!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 4 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 4 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 3 months ago

@williamspatrick has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 months ago

@williamspatrick merged this pull request in facebook/openbmc@e2a5d287543c2f5613c4846f2fa48f56bd2ba144.