search

facebook / prop-types

Runtime type checking for React props and similar objects
MIT License
4.48k stars 356 forks source link

Updated all vars in test files to consts and lets. #171

Closed barrymichaeldoyle closed 6 years ago

barrymichaeldoyle commented 6 years ago

It's better to define variables as consts and lets over vars.

barrymichaeldoyle commented 6 years ago

Doesn't the babel preset sort that out?

ljharb commented 6 years ago

In the test files, i suppose, but none of the production files in this repo get run through babel.

barrymichaeldoyle commented 6 years ago

Ah right, didn't realize that. I'll update the PR to only update the tests.

barrymichaeldoyle commented 6 years ago

There we go, I reset back to the commits that only affect the test files 👍

gaearon commented 6 years ago

Seems fine, thanks. A PR adding a Babel step would also be great!