Support validation when hasOwnProperty is not in prototype

dferber90 commented 6 years ago

Avoids the Warning: Failed prop type: propValue.hasOwnProperty is not a function warning when hasOwnProperty is not defined in the prototype chain.

See #183 for details.

On the original issue @ljharb noted something about delete Object.prototype.hasOwnProperty being a thing. I did not quite get this comment, so this solution might not work because of that. Just close this PR in that case.
I did not add tests for the combined case of PropTypes.shape({ q: PropTypes.objectOf(PropTypes.string) }) I pointed out in https://github.com/facebook/prop-types/issues/183#issuecomment-392545102, as I didn't know where to place them

dferber90 commented 6 years ago

I moved the declaration to module scope now (amended the commit) and added a test for objects with a hasOwnProperty property.

mhuggins commented 5 years ago

Thanks for this fix! Running into this as well. Is there a reason it sits open?

dferber90 commented 5 years ago

@mhuggins It is ready to be merged from my side (aside from the merge conflicts now).

ljharb commented 5 years ago

Rebased this; it's partially addressed by #112 but still includes tests and a fix.

mhuggins commented 5 years ago

Thanks, guys! ❤️

facebook / prop-types

Support validation when hasOwnProperty is not in prototype #187