@types/prop-types & @types/react has circular dependency

facebook / prop-types

Runtime type checking for React props and similar objects

MIT License

4.48k stars 356 forks source link

@types/prop-types & @types/react has circular dependency #215

Closed adisbladis closed 6 years ago

adisbladis commented 6 years ago

Circular dependencies are a huge issue when working with third party tooling (graphing dependencies, integrating into other build systems etc).

I think the correct solution here would be to put @types/react in the bundleDependencies (https://docs.npmjs.com/files/package.json#bundleddependencies) attribute in package.json to make the circular dependency invisible to consumers of this package.

ljharb commented 6 years ago

Neither of those packages are part of this repo, nor dependencies in it. You'll need to file this kind of issue in DefinitelyTyped.

adisbladis commented 6 years ago

Sorry for the confusion