search

facebook / prop-types

Runtime type checking for React props and similar objects
MIT License
4.48k stars 356 forks source link

Prop type for Text styles? #228

Closed niftylettuce closed 6 years ago

niftylettuce commented 6 years ago

Not sure what to use here for <Text> valid prop types - there isn't clear documentation. Same for <View>.

niftylettuce commented 6 years ago

Currently receiving the screenshot below console warning for https://github.com/joinspontaneous/react-native-loading-spinner-overlay (widely used cross-platform spinner package for React Native projects):

screen shot 2018-10-13 at 8 11 02 pm

Ref:

To reproduce, clone the repo linked above, cd example and yarn then yarn run example and react-native run-ios.

ljharb commented 6 years ago

This sounds RN-specific; I’m not sure it belongs in this library (any more than DOM-specific propTypes would).

niftylettuce commented 6 years ago

I will file this in the RN repo, thanks @ljharb