facebook / prop-types

Runtime type checking for React props and similar objects
MIT License
4.48k stars 356 forks source link

Optimize #268

Closed noscripter closed 5 years ago

noscripter commented 5 years ago
TrySound commented 5 years ago

@noscripter NODE_ENV is replaced statically with bundler for browsers. It should not be extracted.

noscripter commented 5 years ago

@noscripter NODE_ENV is replaced statically with bundler for browsers. It should not be extracted.

Thanks for that info, can you provide more detail for me to dive into?

TrySound commented 5 years ago

This convention is shared across many packages (especially react ones) https://github.com/rollup/rollup-plugin-replace https://webpack.js.org/guides/production/#specify-the-mode

noscripter commented 5 years ago

This convention is shared across many packages (especially react ones) https://github.com/rollup/rollup-plugin-replace https://webpack.js.org/guides/production/#specify-the-mode

Coool, thanks.