search

facebook / prop-types

Runtime type checking for React props and similar objects
MIT License
4.48k stars 356 forks source link

[Dev Deps] update `eslint` #290

Closed conartist6 closed 5 years ago

conartist6 commented 5 years ago

Upgrades eslint to fix JSX errors in test files. Updates eslint config to represent how the code is written. Fixes a few minor issues reported by the linter.

conartist6 commented 5 years ago

@ljharb I believe that without at least a preset eslint does not execute any rules at all. I checked their docs while making this PR, to be specific. Are you sure your preference is not to execute any rules on the actual sources?

ljharb commented 5 years ago

At the moment eslint is primarily there to check for syntax; given that this is a project I'm maintaining but don't have final decisionmaking authority on, it wouldn't be up to me to enable wide swaths of rules at this time.

conartist6 commented 5 years ago

You couldn't even find some relatively unopinionated set of rules that is possible to enable? It would really do your contributors the favor to be able to point out undefined symbols and assignments to consts and that manner of thing. But my IDE can't even highlight those things because in this project they aren't errors.

conartist6 commented 5 years ago

I'm also confused as to why you left the various configuration pieces which turn rules off, given that there are no rules.