search

facebook / prop-types

Runtime type checking for React props and similar objects
MIT License
4.48k stars 358 forks source link

Fix bad variable name #387

Closed Rovel closed 1 year ago

Rovel commented 1 year ago

Hi, by accident I found this ENV var I thought that the name of the variable could have a better name considering its open source now I would love to have the hacktoberfest tag on this PR if it makes sense merging

ljharb commented 1 year ago

No thanks, there's no value in changing this.

Rovel commented 1 year ago

It's sad that you don't see value in changing a variable that contains a threat in it to become something less threatening, especially since the threat doesn't make sense for 99% of the people that run this code in 2022.

ljharb commented 1 year ago

It's intended to be maximally threatening - and the warning was added after the project was made open source.