search

facebook / prop-types

Runtime type checking for React props and similar objects
MIT License
4.48k stars 358 forks source link

Update to newest version #412

Closed MichaelBuessemeyer closed 3 months ago

MichaelBuessemeyer commented 3 months ago

Synched upstream changes from facebook/prop-types to update to latest version commit

facebook-github-bot commented 3 months ago

Hi @MichaelBuessemeyer!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

MichaelBuessemeyer commented 3 months ago

Sorry my bad, wrong origin

ljharb commented 3 months ago

Why is a fork needed? What changes are you trying to add?

MichaelBuessemeyer commented 3 months ago

Sorry for this PR. I accidentally opened it to the original repo as Github configures this a default :/ So please ignore this PR.

What changes are you trying to add?

We modified type-props to include the warnings even in production. Each process.env.NODE_ENV !== 'production' is replaced with true.

ljharb commented 3 months ago

Gotcha. That's something you can do transparently with a bundler without the need to fork, fwiw :-)