Should not call `fig.tight_layout()` unconditionally

[davidgilbertson]

I'm calling plot() on a model and passing in an ax, which is then used to plot the function.

This ax exists in a figure that is using constrained layout, rather than tight layout.

The issue is that the Prophet plot function calls fig.tight_layout() on this line.

I think it should either:

• Not do this if the user passes in an ax. In this case they're essentially saying "this is your canvas, draw onto this, please" and to reach up into the parent figure and change things is overstepping those bounds. OR
• Check fig.get_tight_layout() before calling fig.tight_layout().

In fact, the internals of tight_layout()/subplots_adjust() does indeed check for the use of constrained layout and logs a warning, but this warning gets swallowed somewhere.

My workaround in the meantime is to just reset back to the rcParams values with:

m.plot(forecast, ax=ax).set_constrained_layout(None)

[pranith7]

@tcuongd i want to work on this issue

[adit299]

@pranith7 Did you make any progress on this issue? I would like to take a look.

[alhridoy]

Hi @tcuongd I created a PR addressing this issue. Would you please check that.

[sivapungamuru]

nice thank you

[richardtorres314]

@tcuongd Would #2504 merged consider this closed? Thank you!