search

facebook / proxygen

A collection of C++ HTTP libraries including an easy to use HTTP server.
Other
8.04k stars 1.47k forks source link

Build fails if liburing is installed #434

Closed jmccl closed 1 year ago

jmccl commented 1 year ago

[ 89%] Linking CXX executable SessionTests /usr/bin/ld: ../../../../../deps/lib/libfolly.a(IoUringBackend.cpp.o): in functionfolly::IoUringBackend::delayedInit()': /home/john/third-party/proxygen/proxygen/_build/deps/folly/folly/experimental/io/IoUringBackend.cpp:1361: undefined reference to io_uring_enable_rings' collect2: error: ld returned 1 exit status make[2]: *** [proxygen/lib/http/session/test/CMakeFiles/SessionTests.dir/build.make:266: proxygen/lib/http/session/test/SessionTests] Error 1 make[1]: *** [CMakeFiles/Makefile2:1612: proxygen/lib/http/session/test/CMakeFiles/SessionTests.dir/all] Error 2 make: *** [Makefile:146: all] Error 2

This appears to have resulted from this recent folly commit, adding a call to io_uring_enable_rings.

https://github.com/facebook/folly/commit/07903eb9b8962ddcf0132dc136e0e1d7fc9368cb

jmccl commented 1 year ago

Fixed here:

https://github.com/facebook/folly/issues/1908

jmccl commented 1 year ago

This is still broken on Manjaro (and I assume any Arch based distros.)

jmccl commented 1 year ago

Was fixed by this.

https://github.com/facebook/folly/commit/259c9d6a4f0eb6d80e0263c2fe5d1af5bff116dc