facebook / pyre-check

Performant type-checking for python.
https://pyre-check.org/
MIT License
6.86k stars 437 forks source link

doc: Require Python3.8 to sapp #787

Closed WangGithubUser closed 1 year ago

WangGithubUser commented 1 year ago

Pre-submission checklist

Summary

sapp require Python3.8 since facebook/sapp@27b4220789a97045a879e4a9e51d6a26751675ec

Test Plan

N/A

kinto0 commented 1 year ago

it seems like the docs say 3.7?

https://pypi.org/project/fb-sapp/#:~:text=To%20run%20SAPP%2C%20you%20will%20need%20Python%203.7%20or%20later.

WangGithubUser commented 1 year ago

https://github.com/facebook/sapp/blob/main/README.md?plain=1#L17 The pypi page is outdated.

facebook-github-bot commented 1 year ago

@alexkassil has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@alexkassil merged this pull request in facebook/pyre-check@689a8bed35d3ab2a134a9bfb0c49845764760361.