Closed WangGithubUser closed 11 months ago
@inseokhwang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Sorry, we went ahead and removed the param usage without the try/except clause because it's a bad practice to except errors in tests that are not intended.
https://github.com/facebook/pyre-check/commit/157e3d91b83b3ddc885ff3306c075e58a0eaf2f9
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit install
pre-commit run
Summary
The GitHub Action
Tests
failed because keyword ignore_cleanup_errors fortempfile.TemporaryDirectory
is added in Python 3.10 and is incompatible to 3.8, 3.9 As a temp batch, we could use an equivalent form of it.After we drop 3.8 and 3.9, we could back out this PR.Test Plan
See if the GitHub Action passed.