Treat *.ml{i} in Linguist as OCaml

facebook / pyre-check

Performant type-checking for python.

https://pyre-check.org/

MIT License

6.85k stars 437 forks source link

Treat *.ml{i} in Linguist as OCaml #817

Closed kevinji closed 7 months ago

kevinji commented 8 months ago

Pre-submission checklist

[x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
[x] pre-commit run

Summary

Some files (see the screenshot below) are being incorrectly recognized as SML instead of OCaml by Linguist. This change explicitly marks *.ml{i} files as always OCaml for Linguist.

Test Plan

N/A

kevinji commented 7 months ago

@connernilsen are you a good person to review this PR? If not, is there someone else who can look at this?

kevinji commented 7 months ago

Or maybe @grievejia?

connernilsen commented 7 months ago

This looks like a pretty simple change @kevinji. Let me pull it in and see what others think :)

facebook-github-bot commented 7 months ago

@connernilsen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 7 months ago

@connernilsen merged this pull request in facebook/pyre-check@31e351c81cd0410ca1138c237cd1928ddafc909b.