Closed cclauss closed 4 months ago
@migeed-z has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Perhaps PyPy should be moved to a separate pull request because that GitHub Action test has been running for 3+ hours.
@migeed-z has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@migeed-z merged this pull request in facebook/pyre-check@714c268e940efe827c790a0eb81ef983643b3887.
Generated:
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit install
pre-commit run
Summary
Related to:
827
821
816
PEP 604 – Allow writing union types as
X | Y
-- https://peps.python.org/pep-0604On Python < 3.10 the tests are failing on PEP 604 type annotations which will be enforced by
ruff rule UP007
.On Python < 3.10 the source file must start with
from __future__ import annotations
to be able to use PEP 604 syntax.Test Plan