facebook / pyre-check

Performant type-checking for python.
https://pyre-check.org/
MIT License
6.8k stars 434 forks source link

Py3.13: `logging.warn()` is removed in favor of `logging.warning()` #842

Closed cclauss closed 4 months ago

cclauss commented 4 months ago

Pre-submission checklist

Summary

Temporarily add Python 3.13 alpha 6 to the GitHub Actions and see what fails...

% ruff check --select=LOG009,G010

api/query.py:287:21: G010 [*] Logging statement uses `warn` instead of `warning`
client/commands/code_navigation.py:203:17: G010 [*] Logging statement uses `warn` instead of `warning`
client/commands/code_navigation.py:233:17: G010 [*] Logging statement uses `warn` instead of `warning`
client/commands/daemon_querier.py:987:17: G010 [*] Logging statement uses `warn` instead of `warning`
client/commands/info.py:65:17: G010 [*] Logging statement uses `warn` instead of `warning`
tools/upgrade/commands/codemods.py:88:17: G010 [*] Logging statement uses `warn` instead of `warning`
tools/upgrade/commands/configurationless.py:283:17: G010 [*] Logging statement uses `warn` instead of `warning`
tools/upgrade/commands/configurationless.py:309:17: G010 [*] Logging statement uses `warn` instead of `warning`
Found 8 errors.
[*] 8 fixable with the `--fix` option.

% ruff check --select=LOG009,G010 --fix

Found 8 errors (8 fixed, 0 remaining).

Test Plan

Temporarily add Python 3.13 alpha 6 to the GitHub Actions and see what fails. Fix it and remove Python 3.13 alpha 6 from the GitHub Actions.

facebook-github-bot commented 4 months ago

@migeed-z has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 4 months ago

@migeed-z merged this pull request in facebook/pyre-check@16097edd5bbea2b74beebe463368ae14e6e09bf9.