search

facebook / pyre-check

Performant type-checking for python.
https://pyre-check.org/
MIT License
6.79k stars 432 forks source link

Don't use patch for pyre in upgrade tests [2/n] #851

Closed stroxler closed 3 months ago

stroxler commented 3 months ago

Summary: This is the second of two commits removing the use of unittest.patch on pyre-internal functions and classes; instead we need to always use patch.object to avoid getting errors on invalid names in github CI.

Differential Revision: D57359461

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D57359461

stroxler commented 3 months ago

closing - PR failed, I need to stack more changes

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D57359461

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D57359461

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D57359461

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D57359461