Remove dead `pyre-ignore` directives - Githubissues

facebook / pyre-check

Performant type-checking for python.

https://pyre-check.org/

MIT License

6.79k stars 432 forks source link

Remove dead `pyre-ignore` directives #855

Closed stroxler closed 3 months ago

stroxler commented 3 months ago

Summary: The dataclasses-json version we are getting in github has types that are incompatible with the internal version. As a result, we need to pin the version on github to get comparable results (in addition it's at least possible we would get bugs in open-source without pinning). I filed T189226004 to bump the version internally.

In addition:

we aren't marking toml as a dependency, but we need it as a dev dependency because type checking the typeshed patcher requires it
we need to list both tabulate and toml in our .pyre_configuration for github to pick them up because we are still using the legacy setup where packages aren't picked up by default... this would probably be good to change at some point.

Differential Revision: D57433947

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D57433947

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D57433947

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D57433947

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D57433947

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D57433947

facebook-github-bot commented 3 months ago

This pull request has been merged in facebook/pyre-check@998b5d3b5641cc2b814fcf8578dcfadae4a23ac6.