Closed esohel30 closed 2 months ago
Hi @esohel30!
Thank you for your pull request and welcome to our community.
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@arthaud has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@arthaud merged this pull request in facebook/pyre-check@4ca715507305381617be3984d539a75562fc1956.
870
This pull request addresses the issue of warnings related to classes with a high number of overrides in Pysa. It includes the following changes:
Update Override Warning Messages:
Enhanced the warning messages for classes with many overrides to include a suggestion to use the maximum_overrides_to_analyze option. Added a link to the relevant documentation for further guidance.
Configuration Updates:
Added the maximum_overrides_to_analyze option to the taint.config files for different exercises to improve analysis performance and reduce warning messages.
Please provide any feedback as comments for this pull request. I will then apply the feedback and update the code.