search

facebook / pyre-check

Performant type-checking for python.
https://pyre-check.org/
MIT License
6.79k stars 432 forks source link

Try fixing github build: install only opam with apt #893

Closed stroxler closed 1 month ago

stroxler commented 1 month ago

Summary: The build in github is currently broken due to a dune version mismatch.

I think the problem is that our workflow is incorrectly getting dune from an apt download rather than our opam switch; trying to see what happens if we only apt install opam.

Differential Revision: D59591828

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D59591828

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D59591828

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D59591828

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D59591828

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D59591828

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D59591828

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D59591828

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D59591828

stroxler commented 1 month ago

I'm going to leave this up for now... the latest results seem to show that setup.py's PATH is somehow not making it all the way into the makefile logic behind make dev.

See these logs: https://github.com/facebook/pyre-check/actions/runs/9911237956/job/27383440089?pr=893

It's pretty easy to see the path logged out from setup.py does not match what the Makefile sees, and this is why the Makefile can't find dune.

I'm pretty stumped about why; I know for sure that environment variables set at the top level do make it.