Fix pysa step in github CI after dune lang bump

facebook / pyre-check

Performant type-checking for python.

https://pyre-check.org/

MIT License

6.79k stars 432 forks source link

Fix pysa step in github CI after dune lang bump #896

Closed stroxler closed 1 month ago

stroxler commented 1 month ago

Summary: Prior to this commit, we were relying on an apt installed dune rather than the dune from the OPAM switch to build Pyre in the pysa github job.

This wasn't obvious - for reasons I don't really understand right now, the env passed from setup.py that includes the opam switch bin directory on PATH isn't making into the Makefile action (see the TODO).

A workaround is to just set the PATH manually.

Differential Revision: D59693879

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D59693879

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D59693879

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D59693879

facebook-github-bot commented 1 month ago

This pull request has been merged in facebook/pyre-check@553bea60d73dcd041ad90742080f917da09eaf6c.