arthaud
commented
2 months ago Hi @yoann-marquer, thanks for reaching out.
There are multiple problems here.
First, pysa finds your virtual environment and includes it in its analysis. This is usually the desired behavior. Then, while type checking numpy (in your virtual environment), it seems to hit a performance regression or worse, an infinite loop. This is quite surprising but could simply be a bug in pyre. cc @stroxler and @grievejia in case this is known or if they want to look at it (but usually this is unfortunately low priority for us, unless we have the same problem internally).
so, first of, make sure you are using the latest version of pyre. I would even recommend trying with the pyre-check-nightly pypi package.
Then, to prevent pysa from looking at your virtual environment, you should be able to add "site_package_search_strategy": "none" in the .pyre_configuration file, which should be located in pyre-check-clean/documentation/pysa_tutorial/exercise1/.pyre_configuration.
See https://pyre-check.org/docs/configuration/ for more information about the pyre configuration file.
An alternative would be to simply exclude numpy.lib.tests.test_format.$toplevel from the analysis.
This could be done by adding the following lines in a pysa model file (.pysa):
@SkipAnalysis
def numpy.lib.tests.test_format.__top_level__(): ...For instance, you could add this to pyre-check-clean/documentation/pysa_tutorial/exercise1/sources_sinks.pysa.
EDIT: Fixed missing : ... in the SkipAnalysis model.
yoann-marquer
Pysa Bug
Pre-submission checklist [✓] I've checked the list of common issues and mine does not appear
Bug description Pysa execution of a tutorial example does not terminate when done inside another project environment.
Reproduction steps I cloned the pyre-check repository and successfully executed on my machine the Pysa tutorial on a newly created virtual environment, following the instructions in the pysa_tutorial directory.
Then, I tried to reproduce example 1 using my project virtual environment. My project main directory (named
SagaDatabase) has the following structure:venvpyre-check-cleanI installed the necessary requirements using:
pip3 install pyre-check fb-sapp django-stubsthen I moved to the first exercise:cd ./pyre-check-clean/documentation/pysa_tutorial/exercise1in order to analyse the code snippet present in the directory:pyre --noninteractive analyze --no-verifyExpected behavior I expected Pysa execution to terminate after a few seconds, as for my initial test using a standalone instance of the
pyre-checkrepository and a fresh virtual environment.Logs
Additional context I'm interested only in analyzing small code snippets (like the
views.pyfile in the first exercise), not whole projects. The error indicates thatThe type check of numpy.lib.tests.test_format.$toplevel is taking more than 960 secondswhich is unrelated to the first example of the tutorial. Is there a way to restrict the type check to code snippets at given paths or in a given directory?