Closed rachelnabors closed 4 years ago
Hi @rachelnabors,
One question, sorry for my naivety, if I am converting a class example into functional example (just converting the snack from class to function) do I keep both the snacks? Also, do I explicitly mention <block class="functional syntax" />
in each snack?
(I)f I am converting a class example into functional example (just converting the snack from class to function) do I keep both the snacks?
Yes!
Also, do I explicitly mention
<block class="functional syntax" />
in each snack?
It's probably best for you to copy the code block under "Convert existing example code to use function components and Hooks," then replace // Class Example goes here
with the former, class-based example. Then replace // Function Example goes here
with a function/Hooks example.
Please correct me if I misunderstood your question!
Thank you so much. I understood the point of the whole code block. I should have read the class name on the top that says toggler
. 😅 It clearly says what it does.
I have updated my PR according to the code block.
@amandeepmittal Did you follow steps 3 and 4, too? ;)
@rachelnabors Just created a PR for the DatePickerIOS 🗓. I basically rewrote the existing class component into a functional component with hooks. But It clearly has a lot of props, does the Snack have to cover all the props or basic functionality is enough?
You know, DatePickerIOS is actually in the process of being deprecated! It sneaked into the table somehow (tsk tsk!). I just removed it. I'm accepting your PR regardless, but go pour your energy into another component who will be sticking around!
@rachelnabors do you have copy-paste version of the matrix table? Also should quote the matrix here or in the PR?
You know, DatePickerIOS is actually in the process of being deprecated! It sneaked into the table somehow (tsk tsk!). I just removed it. I'm accepting your PR regardless, but go pour your energy into another component who will be sticking around!
It did well for a test subject 😜 will pick up something more vital next...
@rachelnabors do you have copy-paste version of the matrix table? Also should quote the matrix here or in the PR?
@amandeepmittal, are you not able to edit the original post? I tried to put checkboxes in there but couldn't make them work inside tables! Thanks for bearing with me!
@rachelnabors do you have copy-paste version of the matrix table? Also should quote the matrix here or in the PR?
@amandeepmittal, are you not able to edit the original post? I tried to put checkboxes in there but couldn't make them work inside tables! Thanks for bearing with me!
Nope. Can't edit your original post here. No worries. Thank you getting back to me so quickly.
Hmm. Gonna have to think of a way for people to claim each task..
Hmm. Gonna have to think of a way for people to claim each task..
Can we do this in a gist and link it here? Just a suggestion 🤷♂️
I added checkboxes :) Just tick one for each task you claim. I'll update them to bold checks when the PRs are merged!
I’d like to claim the Animated
API up-to-date; how do I check off one of those boxes? Maybe it just doesn’t work since I’m on mobile
I’d like to claim the
Animated
API up-to-date; how do I check off one of those boxes? Maybe it just doesn’t work since I’m on mobile
I'd like to pick this one up too. Given the size of the API, can we share this between us?
Why don't you both split the load? I'll put your names down for the different tasks (since the checkboxes aren't working!). How do you want to split it?
Hi there, I would like to claim for View Style Prop
@rachelnabors I could document the API for Animated.Value
/Animated.ValueXY
, and leave the rest of Animated
to @DaniAkash
@mitulsavani You got it! Don't forget to reference this issue in your PR!
@rachelnabors feel free to assign <SectionList />
to me!
@rachelnabors I'll take the ImageBackground :)
@rachelnabors I'll take TouchableHighlight
:)
@rachelnabors here goes my first PR, https://github.com/facebook/react-native-website/pull/1590
@rachelnabors Can I take Modal
? Thank you :heart:
@rachelnabors I can take Image Style Props
? Thanks 👍
@rachelnabors Can I take Switch
? Thanks!
@rachelnabors I'll take Button
next :)
@rachelnabors I'll work on View
to add snack and functional component example.
Thanks for volunteering, everyone! I've updated the matrix with all your commitments. For anyone who hasn't got a component or API to work on, we still have plenty left! Jump on in!
@rachelnabors I did also a small adjustment in Picker
and TouchableOpacity
components examples. :grin:
@jeremy-deutsch cool I'm up for the task ✌️
@rachelnabors
Hello! I am super interested and making this contribution. As I understand it, is it necessary to make an example with hooks and classes referring to the API?
Example: Let's go up and get the Pixel Ratio Do I have to do the example in the snack using Classes and hooks? Right?
If not, please let me know!
I'm waiting!
@rachelnabors Just pushed out an example for the Alert component. Clipboard
, Dimensions
, Keyboard
& LayoutAnimations
are next!
Also will be picking up the Animated API which will be quite a challenging task! 😁
I'm unable to get the Clipboard
working on the Expo web player. Could use some help with https://github.com/facebook/react-native-website/pull/1599
Hello
FOA navigating the table is quite tedious, can you please make it a little bit easier.
I would like to work on the Keyboard
.
Hello FOA navigating the table is quite tedious, can you please make it a little bit easier. I would like to work on the
Keyboard
.
@ahmdtalaat I'll be leaving the Keyboard
in your care 👍 Picking up LayoutAnimations
next! ✏️
@rachelnabors it'd be great if you can create a PR column to the Components and APIs update progress table and list the PRs raised related to the component. It'll greatly help the PRs to be peer-reviewed and tracked neatly ✏️
@rachelnabors Can I take VirtualizedList
?
@rachelnabors, I took the clipboard API.
@rachelnabors, I took the clipboard API.
@brunokiafuka There's already a PR open for this API - https://github.com/facebook/react-native-website/pull/1599
@rachelnabors, I took the clipboard API.
@brunokiafuka There's already a PR open for this API - #1599
Sorry @DaniAkash, I've missed that
@rachelnabors, I took the clipboard API.
@brunokiafuka There's already a PR open for this API - #1599
Sorry @DaniAkash, I've missed that
@brunokiafuka I can use your help in it 👍 it is WIP
@rachelnabors feel free to assign LayoutAnimation Snack example and Hooks example to me!
@rachelnabors feel free to assign LayoutAnimation Snack example and Hooks example to me!
@hugobytes I'm almost done with the LayoutAnimation. Will be sending a PR soon.
Hi @rachelnabors will be taking the KeyboardAvoidingView. I will be working on Example uses Snack and Example uses function components and Hooks for that componenet
Hi @rachelnabors, I will be taking the Text and working on Example uses function components and Hooks.
@ronnyiscoding Are you working on the VirtualizedList precisely on Example uses Snack
and Example uses function components and Hooks
for that component, if not can I take it from you?
@ronnyiscoding Are you working on the VirtualizedList precisely on
Example uses Snack
andExample uses function components and Hooks
for that component, if not can I take it from you?
ok, it is fine.
Ok then @rachelnabors I'll be taking VirtualizedList from @ronnyiscoding precisely on Example uses Snack
and Example uses function components and Hooks
Ok then @rachelnabors I'll be taking VirtualizedList from @ronnyiscoding precisely on
Example uses Snack
andExample uses function components and Hooks
@nnajiabraham I mentioned you in this PR https://github.com/facebook/react-native-website/pull/1607
🍾🎉🎈Thank you everyone! We are mission complete!🍾🎉🎈
We have a lot of component and API docs that need updating! The good news is that updating these docs can be a fun way to become more familiar with React Native’s core code while contributing to docs that help thousands of learners around the world! If this looks intimidating, we have you covered! There’s a handy guide below that should help you out :)
What needs updating?
How to contribute?
When your PR is merged, we’ll convert your name into a checkmark, indicating completion!
Update the API to reflect the props and methods reflected in core
This part requires a little investigating! Check react-native/Libraries/YourComponent and react-native/Libraries/Components/YourComponent for your component or API’s list of props. Sometimes they can be hidden, like the LayoutProps API is in react-native/Libraries/StyleSheet/StyleSheetTypes.js.
Add missing example code
If there is no example code, add a new example using function components and Hooks. Embed your code with a Snack player like so:
If there isn’t a class component example or there was already a function component example, just use the following code to embed just a function component example.
Embed any example code with a Snack player