search

facebook / react-native-website

The React Native website and docs
https://reactnative.dev
MIT License
1.94k stars 4.36k forks source link

feat: add iOS, Android tags into platform-specific #4097

Closed apicgg closed 5 months ago

apicgg commented 5 months ago

This PR enhances the platform specific page with tags and hover tooltips on the tags.

This PR is partial completion of #3047

netlify[bot] commented 5 months ago

Deploy Preview for react-native ready!

Name Link
Latest commit 59f8f119bb66213f21edf8dd80da4a8b9ea62baf
Latest deploy log https://app.netlify.com/sites/react-native/deploys/6630bfed19aad40008faf4bd
Deploy Preview https://deploy-preview-4097--react-native.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

apicgg commented 5 months ago

@cortinico Yea, sure. Done, I have now pushed the changes to update the non-versioned doc as well.

Also does it make sense to add the title tooltip for the platform-specifics page only for the tags? Or maybe we add this for all other pages where the tags have been used in future?

cortinico commented 5 months ago

Also does it make sense to add the title tooltip for the platform-specifics page only for the tags? Or maybe we add this for all other pages where the tags have been used in future?

I think it makes sense to add the title= to all the pages where the tag is used 👍

apicgg commented 5 months ago

Also does it make sense to add the title tooltip for the platform-specifics page only for the tags? Or maybe we add this for all other pages where the tags have been used in future?

I think it makes sense to add the title= to all the pages where the tag is used 👍

@cortinico Understood. Could you please approve and merge this? Will work on the other pages with a separate PR.