search

facebook / react-native-website

The React Native website and docs
https://reactnative.dev
MIT License
1.94k stars 4.36k forks source link

Documentation on TextInput style references an abandoned bug #4101

Closed mjaggard closed 4 months ago

mjaggard commented 5 months ago

Description

On this page https://reactnative.dev/docs/textinput#style the bug https://github.com/facebook/react-native/issues/7070 is referenced but that bug is locked and abandoned. Either the docs should not reference it, or the bug should be revived.

Documentation version

0.74 next

apicgg commented 5 months ago

@mjaggard Does it still make sense to reference the bug ID into the docs even though the bug has been closed? Whoever is visiting the docs for the fist time, it will give them some understanding about this.

mjaggard commented 5 months ago

But the understanding it gives is "nobody can be bothered to check which styles work and document it correctly". Or possibly "valid bugs will be closed after some time regardless of whether they're important - even if they're important enough that they're in the documentation pages"

apicgg commented 5 months ago

@mjaggard Got it. Thanks for explaining.

apicgg commented 4 months ago

@cortinico Would like to know your thoughts on this. Thanks in advance.

cortinico commented 4 months ago

We should just remove the reference to the issue from the docs. Happy to review a PR about it

apicgg commented 4 months ago

We should just remove the reference to the issue from the docs. Happy to review a PR about it

@cortinico #4108