search

facebook / react-native-website

The React Native website and docs
https://reactnative.dev
MIT License
1.91k stars 4.34k forks source link

Add hover text for tags in ScrollView #4116

Closed apicgg closed 1 month ago

apicgg commented 1 month ago

@cortinico I know it's not much but it adds the hover text on platform tags for ScrollView page.

see #3047

netlify[bot] commented 1 month ago

Deploy Preview for react-native ready!

Name Link
Latest commit d343dff833e39ba45a0dbf45fc175182c6c6104c
Latest deploy log https://app.netlify.com/sites/react-native/deploys/664517b9aef8040008cc0735
Deploy Preview https://deploy-preview-4116--react-native.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Simek commented 1 month ago

Thanks for working on this improvement! 👍

We probably should make the platform tag a component, which accepts platform prop and based on that render the correct content, so we don't need to copy over the alt text to every platform mark use-case across smany doc pages. But this also meant that we need to replace all manual HTML header additions with new component.

Please let me know if you are interested in trying to introduce this new component and address the issue in more comprehensive way. Happy to help you with this, but if you are not interested it's also fine, I can make a follow up PR in the future.

apicgg commented 1 month ago

@Simek Making it a platform tag component sounds good. I am more than happy and interested to help introducing this new component. Thanks.

apicgg commented 1 month ago

This is being fixed by #4132