facebook / react-native-website

The React Native website and docs
https://reactnative.dev
MIT License
1.91k stars 4.34k forks source link

docs: Fix hero styles content outside viewport (width) #4119

Closed LucasReinaldo closed 1 month ago

LucasReinaldo commented 1 month ago

Patch to fix hero image going outside viewport.

Screenshot 2024-05-18 at 11 44 16
facebook-github-bot commented 1 month ago

Hi @LucasReinaldo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

netlify[bot] commented 1 month ago

Deploy Preview for react-native ready!

Name Link
Latest commit 9cd3f032e087d009d1d7ca708524df7d320afb29
Latest deploy log https://app.netlify.com/sites/react-native/deploys/664746d494a2620008c95e0f
Deploy Preview https://deploy-preview-4119--react-native.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Simek commented 1 month ago

Hey @LucasReinaldo, thanks for putting the fix out so quickly! 🙏

Unfortunately, I had to ship #4127 instead, due to missing CLA check on your PR, hope you can understand that.

LucasReinaldo commented 1 month ago

Hey @LucasReinaldo, thanks for putting the fix out so quickly! 🙏

Unfortunately, I had to ship #4127 instead, due to missing CLA check on your PR, hope you can understand that.

That's all good, my bad for not getting back to it, just subscribed and happy to help anytime.