search

facebook / react-native-website

The React Native website and docs
https://reactnative.dev
MIT License
1.91k stars 4.34k forks source link

Fix hover color for "Continue with Expo" link button in dark mode #4124

Closed jaamaalxyz closed 1 month ago

jaamaalxyz commented 1 month ago

Description

What is the problem?

When hovering over the "Continue with Expo" link button, the color becomes too white, making the text inside the button invisible in dark mode.

How can we address it?

Go to the Environment setup page and hover over the Continue with Expo button

Why is it important?

This is a visibility issue, and people with low eye contrast may find it difficult to see the text inside the button when using dark mode.

Who needs this?

Dark mode user

When should this happen (use version numbers if needed)?

The current react native doc website

Screenshot

hover-color-issue
jonsamp commented 1 month ago

Nice find! I will put together a PR to fix this.

jaamaalxyz commented 1 month ago

@jonsamp thanks for the quick response. I have already fixed this locally. If you don't mind, I can send the PR.

jonsamp commented 1 month ago

@jaamaalxyz You're so fast! I also just put up a PR and then just saw this: https://github.com/facebook/react-native-website/pull/4126.

I had a few other things to fix along the way so I put it all in one PR. I am going to talk to @cortinico and try to get mine merged. If it merges, then we can safely close your PR. --Thanks for putting it up!

jaamaalxyz commented 1 month ago

@jonsamp Thanks for letting me know the update. proceed with your PR.