facebook / react-native-website

The React Native website and docs
https://reactnative.dev
MIT License
1.91k stars 4.34k forks source link

fix: add missing icons to supported platforms #4128

Closed szymonrybczak closed 1 month ago

szymonrybczak commented 1 month ago

Before:

CleanShot 2024-05-22 at 01 30 45@2x

After:

CleanShot 2024-05-22 at 01 27 48@2x

netlify[bot] commented 1 month ago

Deploy Preview for react-native ready!

Name Link
Latest commit 8da412787d7e5b89268a30fbbd3c96792a317dc9
Latest deploy log https://app.netlify.com/sites/react-native/deploys/664d2ed3d6a7590008aaa7c6
Deploy Preview https://deploy-preview-4128--react-native.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for react-native ready!

Name Link
Latest commit 6a329065ba5098dd5024ae144badb858eab96c3d
Latest deploy log https://app.netlify.com/sites/react-native/deploys/664e24682e5dc10008370c3e
Deploy Preview https://deploy-preview-4128--react-native.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Simek commented 1 month ago

This is looking great, thanks for the additions! 🙏

One small request - can we also move the visionOS before, watchOS, Web and Windows so the alphabetical order of platforms is retained?

szymonrybczak commented 1 month ago

One small request - can we also move the visionOS before, watchOS, Web and Windows so the alphabetical order of platforms is retained?

Done ✅

cortinico commented 1 month ago

nit: Windows icon is not correct, we should be using this instead: https://fontawesome.com/icons/microsoft?f=brands&s=solid

szymonrybczak commented 1 month ago

nit: Windows icon is not correct, we should be using this instead: https://fontawesome.com/icons/microsoft?f=brands&s=solid

Ah, right. Fixed: https://github.com/facebook/react-native-website/pull/4135