search

facebook / react-native-website

The React Native website and docs
https://reactnative.dev
MIT License
1.91k stars 4.34k forks source link

Migrate to GitHub Actions from CircleCI #4143

Closed apicgg closed 3 weeks ago

apicgg commented 3 weeks ago

Fixes #4137

netlify[bot] commented 3 weeks ago

Deploy Preview for react-native ready!

Name Link
Latest commit 2ef6b132feebec3aab3b63a03fc2c3aaf971fdc5
Latest deploy log https://app.netlify.com/sites/react-native/deploys/666915984740ef000826f7ac
Deploy Preview https://deploy-preview-4143--react-native.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

apicgg commented 3 weeks ago

@cortinico Done as per your comments.

cortinico commented 3 weeks ago

@apicgg seems like both build and lint are failing. Can you look into them and make them green?

apicgg commented 3 weeks ago

@apicgg seems like both build and lint are failing. Can you look into them and make them green?

@cortinico Hey, yeah seems like the GitHub runner is picking up wrong path for the repo. I am checking this right now on how to fix. I have marked it as draft and will let you know once this is ready for review.

Simek commented 3 weeks ago

I am checking this right now on how to fix.

We can use the working-directory: docs param for the scripts that need to be run from docs directory.

apicgg commented 3 weeks ago

I am checking this right now on how to fix.

We can use the working-directory: docs param for the scripts that need to be run from docs directory.

@Simek Any idea why GH Actions is appending the working directory like below? For reference - Action Link

image

Simek commented 3 weeks ago

This is probably throwing due to the configuration mistake (paths seems rigght). I would recommend making the lint and build a separate steps in the same workflow not separated jobs. If you want to retain the current division, you need to move the setup step in into both of the jobs (lint and build). needs only expects the successful run on mentioned job, but the checkouts are not shared.

apicgg commented 3 weeks ago

@cortinico This is ready to review. The lint job is apparently taking longer with default GitHub Actions runners.

Simek commented 3 weeks ago

@cortinico Do you also have in mind moving the deployments previews from CircleCI, or it was about PR checks only?

apicgg commented 3 weeks ago

@Simek I have pushed the changes now.

cortinico commented 3 weeks ago

Do you also have in mind moving the deployments previews from CircleCI, or it was about PR checks only?

I don't think we do deployments of Previews from CircleCI.

cortinico commented 3 weeks ago

Thank you very much for your help @apicgg 🙏