search

facebook / react-native-website

The React Native website and docs
https://reactnative.dev
MIT License
1.92k stars 4.34k forks source link

docs: remove outdated tv docs #4155

Open moskalakamil opened 1 week ago

moskalakamil commented 1 week ago

Since React Native for TV has been moved to a separate repository, information on how to develop for this library should not be included in the main React Native documentation. We should either remove this section entirely or add a link redirecting users to the react-native-tvos Wiki.

netlify[bot] commented 1 week ago

Deploy Preview for react-native ready!

Name Link
Latest commit 3bdbb8a22c5673963c29ff70d9dc951e933c0f71
Latest deploy log https://app.netlify.com/sites/react-native/deploys/668706b9369aa70008010d22
Deploy Preview https://deploy-preview-4155--react-native.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for react-native ready!

Name Link
Latest commit ba656e6a01189bd17b47cb330df94fa1bf71b579
Latest deploy log https://app.netlify.com/sites/react-native/deploys/668bc6bfaa2494000840e262
Deploy Preview https://deploy-preview-4155--react-native.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cortinico commented 1 week ago

@Simek any thoughts on this one?

Simek commented 1 week ago

Let's make sure that @douglowder is fine with that change, and if wiki is a right place to redirect people.

moskalakamil commented 1 week ago

@Simek the official react-native-tvos documentation links to their wiki, thats why I decided to add this link

Simek commented 1 week ago

I have in mind that we might want to split up the redirected group, between those, who use frameworks and those who are not, like we do in new setup environment sections.

For example, for Expo users, we got a dedicated guide on how to build TV apps - https://docs.expo.dev/guides/building-for-tv/ - which is also referenced in the wiki links, and that way we might spare user a link jump.

Also, RN TV wiki seems to contains only one doc page, and rest are an external links do different resources, so it might be more valuable to link people into the doc file directly, which will guide them through the setup.

moskalakamil commented 1 week ago

@Simek Sure, provide me please information on which of these two options we prefer. I would also like to note that if we redirect to TV Wiki, we won't have to worry about updating this subpage in the future, as all TV-related information will be then updated by the react-native-tvos community in their repo

moskalakamil commented 1 week ago

@douglowder done ;)) Should i update earlier docs versions?

douglowder commented 1 week ago

done ;)) Should i update earlier docs versions?

@moskalakamil yes thanks, just the versions that Meta currently supports (I think that is 0.71 and up)

moskalakamil commented 1 week ago

@douglowder finished, thanks for guidance!

douglowder commented 1 week ago

@moskalakamil no problem! I approve the request, although I don't have access to do that in GitHub 😄

moskalakamil commented 1 week ago

@Simek updated 👍