search

facebook / react-native

A framework for building native applications using React
https://reactnative.dev
MIT License
118.37k stars 24.25k forks source link

Some files have conflicting license information #12813

Closed willnorris closed 7 years ago

willnorris commented 7 years ago

The following files have conflicting license information in their headers. They claim to be both a BSD-style license as well as one of either:

They are all js files, so my guess is that you ran a script to add the BSD header to all js files, and they maybe should not have been applied to these? In any event, it's unclear what license is really supposed to apply to these files.

willnorris commented 7 years ago

/cc @jamesgpearce

lacker commented 7 years ago

Hi, I was just chatting with our tools folks about this from your email. We need some linting type thing that makes sure this is all as it is intended. It is somewhat more tricky than you might imagine because of the two mechanisms by which a pull request can be opened. I will find the right people internally to look into this.

lacker commented 7 years ago

@ericvicenti is going to help with the license cleanup and is very excited about getting into the world of licensing-tooling :D

gyehuda commented 7 years ago

Can you give us a sense of the timeframe for this to be fixed. We'd love to use React-Native and feel blocked by the uncertainty of your licensing intent. Thanks!

ericvicenti commented 7 years ago

I'm hoping to get this done by the end of the month, which will allow react-native v0.44 to have this problem resolved. This release-candidate will be available ~April 1st, and the stable release is scheduled for ~May 1st.

ericvicenti commented 7 years ago

Everything other than Examples/UIExplorer should be cleaned up, but unfortunately that is still under the samples license for v0.44

UIExplorer is somewhat tricky to move because it is integrated with our testing setup. I'll figure it out over the next couple weeks, and we will be completely under a consistent license for 0.v45

gyehuda commented 7 years ago

Eric, Are you still on track for the May 1st? Is that for v0.44 or v045?

ejc3 commented 7 years ago

Did this get addressed in the latest release?

hramos commented 7 years ago

Yes, 0.45 should have addressed this.