facebook / react-native

A framework for building native applications using React
https://reactnative.dev
MIT License
118.37k stars 24.25k forks source link

[Packager] Requiring validate.js fails #1640

Closed mosch closed 9 years ago

mosch commented 9 years ago

When requiring validate.js, the packaging fails.

var validatejs = require('validate.js');

However, there is a workaround:

var validatejs = require('validate.js/validate');

nicklockwood commented 9 years ago

@amasad, any thoughts?

ide commented 9 years ago

@mosch I think this might have been fixed in master. What version of react are you using?

mosch commented 9 years ago

@ide tested at 0.5 and 0.6-rc1

ide commented 9 years ago

Hmm https://github.com/facebook/react-native/commit/856469a24b6f0b0998061c1244533b510aee3ddd is in 0.6-stable so this could be a bug.

amasad commented 9 years ago

Rewrote the resolver to implement the exact node resolution algorithm. This will work now.

And sorry for the delay, my attempt at email filtering by mentions failed me but I just discovered about the 'participating' tab in github notifications.

mosch commented 9 years ago

@amasad awesome, thank you!