facebook / react-native

A framework for building native applications using React
https://reactnative.dev
MIT License
119.28k stars 24.35k forks source link

SwipeableFlatList bleeding pixel #21167

Closed Dimous closed 5 years ago

Dimous commented 6 years ago

Environment

React Native Environment Info: System: OS: Windows 10 CPU: x64 Intel(R) Core(TM) i5-3230M CPU @ 2.60GHz Memory: 589.87 MB / 5.45 GB Binaries: Yarn: 1.9.4 - C:\Users\kasim\AppData\Roaming\npm\yarn.CMD npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD IDEs: Android Studio: Version 3.1.0.0 AI-173.4907809

Description

When you swipe an item, you can see "bleeding" on the right of it. It is noticable on a physical device. I guess, "x" property should be rounded.

Please, wait till gif below is loaded

swipablelistview

hramos commented 6 years ago

Thanks for the visual demonstration. Can you include a code sample that we can use to repro this?

Dimous commented 6 years ago

https://snack.expo.io/Bk54hV1tQ

You probably won't see it on emulator or a hdpi-device. I use Samsung Galaxy Note II.

On the screenshot below there is a barely noticeable bleeding. Don't let the blurring of icons mislead you. The edges of swipable items should be crisp (and they are, when the horizontal position has an integer value). bleeding Image is clickable, btw.

kelset commented 5 years ago

Hello there 👋 this issue has been reported for an old version of React Native. Ideally we'd like everyone to be using 0.59 (see the awesome changes it brought) but we know updating can be a pain.

Also, both ListView and SwipeableListView are going to be removed, and your repro uses that.

But please, if it's actually still an issue with 0.59 please comment below and we can reopen it. Even better, please send us a pull request with a fix 😊