iOS: returnKeyType is not localized for numeric TextInput

ASchwad commented 4 years ago

Description

The return key for a numeric TextInput is not localized to the OS Language of the user.

On a default alphabetic input, the "done" button is correctly localized.

React Native version:

System: OS: macOS 10.15.3 CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz Memory: 43.03 MB / 16.00 GB Shell: 3.2.57 - /bin/bash Binaries: Node: 12.16.0 - /usr/local/bin/node Yarn: 1.17.3 - /usr/local/bin/yarn npm: 6.13.4 - /usr/local/bin/npm Watchman: 4.9.0 - /usr/local/bin/watchman SDKs: iOS SDK: Platforms: iOS 13.5, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2 Android SDK: API Levels: 23, 25, 26, 27, 28 Build Tools: 23.0.1, 26.0.1, 28.0.3, 29.0.2 System Images: android-25 | Google APIs Intel x86 Atom, android-28 | Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom, android-29 | Google APIs Intel x86 Atom, android-R | Google APIs Intel x86 Atom IDEs: Android Studio: 3.5 AI-191.8026.42.35.5791312 Xcode: 11.5/11E608c - /usr/bin/xcodebuild npmPackages: react: ^16.9.0 => 16.9.0 react-native: ^0.61.5 => 0.61.5

Steps To Reproduce

Embed the following component:

<TextInput 
              keyboardType = 'numeric'
              returnKeyType='done' 
              />

Expected Results

I expected the return key "done" to be correctly localized to the OS Language, like it is done for non-numeric textInputs

Snack, code example, screenshot, or link to a repository:

chrisglein commented 3 years ago

Related to #28328 and #29457. As with the accessiblity props, returnKeyType isn't localized.

This seems to fall in the "not yet implemented" and really are pending a design for how this should be solved (see the linked issues).

stale[bot] commented 3 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.