Closed PrimulaX closed 2 years ago
cortinico
commented
2 years ago Thanks for your report @PrimulaX
here is my podfile:
I can't see hermes-engine in your podfile, so that's hard to even debug. Is this the podfile after your remove Hermes? Which version of Hermes have you been using?
PrimulaX
commented
2 years ago @cortinico Hi, thanks for your reply. Yes, sorry for that, it's podfile after I delete hermes-engine. I just edit the description.
cortinico
commented
2 years ago Thanks for pointing this out.
- hermes-engine (0.9.0)
That's most likely the issue. ~For RN 0.67.3 you'll have to use Hermes 0.11.x. Former version are not compatible~
EDIT: That's not correct. See comments below
PrimulaX
commented
2 years ago @cortinico Ah I see, Thanks, I'll try that.
cortinico
commented
2 years ago Awesome, please keep us posted
PrimulaX
commented
2 years ago @cortinico Actually I'm unable to update Hermes, Is there any specific way to update it?
cortinico
commented
2 years ago Ideally, if you're on RN 0.67.3 and you do pod install, you should automatically get the correct Hermes version. I would suggest you remove the Podfile.lock and run pod install again.
PrimulaX
commented
2 years ago @cortinico Yes I did try that, but it always install same version Installing React-hermes (0.67.3)
joe-sam
commented
2 years ago Actually the recommended Hermes version for React native 0.67.3 is 0.9.0. It was supposed to be Hermes 0.10.0 but that was to be rolled back to 0.9.0 (which has been stable for a year or more) for something exactly similar to the bug you describe.
You may possibly still somehow be trapped on an incorrect version of Hermes 10 as it was on a Release Candidate, otherwise this looks like a major problem that requires further investigation. Try flushing your watchman and node modules, IOS/Xcode cache etc see stack overflow, and check with the react native upgrade helper.
PrimulaX
commented
2 years ago @joe-sam I did possibly everything but no luck.
joe-sam
commented
2 years ago Guessing there may be some incompatible framework like a testing framework in this case. Try to find one of the offending API like this stackoverflow
PrimulaX
commented
2 years ago @joe-sam If so, its all about Hermes, It was accepted successfully without it. I'll keep searching tho.
PrimulaX
commented
2 years ago It came out that the problem was "react-native-webrtc": "1.98.0"
I did build with "react-native-webrtc": "1.94.2" and Hermes, Apple accept the build
Description
I have upgraded RN up to 0.67.3, then build archive for App Store Connect with Hermes enabled in Podfile, Archive was build successfully but apple still reject the build.
Here is apple's response:
We identified one or more issues with a recent delivery for your app, "APP" 3.2.2 (2). Please correct the following issues, then upload again.
ITMS-90338: Non-public API usage - The app references non-public selectors in APP: addStream:, dataChanged, initWithBuffer:rotation:timeStampNs:, initWithURLStrings:, isBinary, isPassthrough, localDescription, newSocketQueueForConnectionFromAddress:onSocket:, onSuccess:, removeValuesForKeys:completion:, sdp, sendData:, setChannelId:, socket:didAcceptNewSocket:, socket:didConnectToHost:port:, socket:didConnectToUrl:, socket:didReadData:withTag:, socket:didReadPartialDataOfLength:tag:, socket:didReceiveTrust:completionHandler:, socket:didWriteDataWithTag:, socket:didWritePartialDataOfLength:tag:, socket:shouldTimeoutReadWithTag:elapsed:bytesDone:, socket:shouldTimeoutWriteWithTag:elapsed:bytesDone:, socketDidCloseReadStream:, socketDidDisconnect:withError:, socketDidSecure:, stringForType:, typeForString:, videoSource,The app contains one or more corrupted binaries. Rebuild the app and resubmit.. If method names in your source code match the private Apple APIs listed above, altering your method names will help prevent this app from being flagged in future submissions. In addition, note that one or more of the above APIs may be located in a static library that was included with your app. If so, they must be removed. For further information, visit the Technical Support Information at http://developer.apple.com/support/technical/
Then I tried without Hermes and build was accepted.
here is my podfile:
Here is my package.json
Version
0.67.3
Output of
npx react-native infoSystem: OS: macOS 10.15.7 CPU: (4) x64 Intel(R) Core(TM) i5-3210M CPU @ 2.50GHz Memory: 2.95 GB / 16.00 GB Shell: 5.7.1 - /bin/zsh Binaries: Node: 12.22.10 - /usr/local/opt/node@12/bin/node Yarn: Not Found npm: 6.14.16 - /usr/local/opt/node@12/bin/npm Watchman: 4.9.0 - /usr/local/bin/watchman Managers: CocoaPods: 1.11.2 - /usr/local/bin/pod SDKs: iOS SDK: Platforms: iOS 14.4, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2 Android SDK: API Levels: 23, 26, 28, 29, 30 Build Tools: 28.0.3, 29.0.2, 29.0.3, 30.0.2 System Images: android-26 | Google APIs Intel x86 Atom, android-28 | Google APIs Intel x86 Atom, android-29 | Google Play Intel x86 Atom Android NDK: Not Found IDEs: Android Studio: 4.1 AI-201.8743.12.41.7042882 Xcode: 12.4/12D4e - /usr/bin/xcodebuild Languages: Java: 1.8.0_282 - /usr/bin/javac npmPackages: @react-native-community/cli: Not Found react: 17.0.2 => 17.0.2 react-native: 0.67.3 => 0.67.3 react-native-macos: Not Found npmGlobalPackages: react-native: Not Found
Steps to reproduce
Snack, code example, screenshot, or link to a repository
No response