kopax-polyconseil
commented
1 year ago We also have performed the following which was not in the upgrade guide documentation
- Added upgrade of
@types/react,@types/react-domand@types/react-nativenot done within the upgrade. - Added upgrade of
react-native-screento support RN 0.70+ - Added upgrade of
@react-native-async-storage/async-storageto support RN 0.70+ - Use new hermes location in
build.gradle(instead ofhermes-enginenot being in node_modules anymore) - Replace in
MainActivity.javaallBuildConfig.IS_NEW_ARCHITECTURE_ENABLEDwithfalse
Remaining build problem
Android
MainActivity.java:71: error: cannot find symbol BuildConfig.IS_NEW_ARCHITECTURE_ENABLED;:
/home/dka/workspace/github.com/pass-culture/pass-culture-app-native/android/app/src/main/java/com/passculture/MainActivity.java:63: error: cannot find symbol
reactRootView.setIsFabric(BuildConfig.IS_NEW_ARCHITECTURE_ENABLED);
^
symbol: variable IS_NEW_ARCHITECTURE_ENABLED
location: class BuildConfig
/home/dka/workspace/github.com/pass-culture/pass-culture-app-native/android/app/src/main/java/com/passculture/MainActivity.java:71: error: cannot find symbol
return BuildConfig.IS_NEW_ARCHITECTURE_ENABLED;
^
symbol: variable IS_NEW_ARCHITECTURE_ENABLED
location: class BuildConfig
Note: /home/dka/workspace/github.com/pass-culture/pass-culture-app-native/android/app/src/debug/java/com/passculture/ReactNativeFlipper.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
2 errors
FAILURE: Build completed with 2 failures.
Fixed with replace all BuildConfig.IS_NEW_ARCHITECTURE_ENABLED with false
cortinico
Avishayy
github-actions[bot]
gastonrampersad
AdarshJais
chengjunzhang1219
New Version
0.70.6
Old Version
0.68.2
Build Target(s)
iOS/Android
Output of
react-native infoIssue and Reproduction Steps
Hello, since we are stuck succeeding our iOS simulator build within GitHub action due to error
Library not loaded: @rpath/hermes.framework/hermesusing react native 0.68.5 (issue: https://github.com/facebook/react-native/issues/35536 , error log: https://gist.github.com/kopax-polyconseil/cd31322d8d71b664a0c965be7a1607e0), our organization as no other choice than trying (for the second time) to perform the react-native upgrade: according to changelog and documentation hermes/ruby become more stable in futur version.As this is our second attempt, we are seeking help. The upgrade guide differ in many points with our current application, this is the list:
.flowconfigdoes not exist in our project while it isMODIFIEDin upgrade helper: why? <- it seems we don't need it.node-versionas beenADDEDwhile we use.nvmrcto set our version: do we need both ? <- it is unclear if.nvmrcis enoughandroid/app/src/main/java/com/rndiffapp/MainActivity.javadoes not look like ours have big differance from your 0.68.5 version of upgrade guide and must be like version 0.70.6: How do we upgrade ?android/app/src/main/java/com/rndiffapp/newarchitecture/MainApplicationReactNativeHost.javaisMODIFIEDbut does not exist in our project: why? <- it seems we can ignoreandroid/app/src/main/jni/Android.mkisDELETEDbut does not exist in our project: why? <- it seems we can just add it (or ignore?)android/app/src/main/jni/CMakeLists.txtisADDED, but we don't even have aandroid/app/src/main/jnifolder: what should we do? <- it seems we can just add it (or ignore?)android/app/src/main/jni/MainApplicationModuleProvider.cpp,android/app/src/main/jni/MainApplicationModuleProvider.h,android/app/src/main/jni/MainApplicationTurboModuleManagerDelegate.cpp,android/app/src/main/jni/MainApplicationTurboModuleManagerDelegate.h,android/app/src/main/jni/MainComponentsRegistry.cppare alsoMODIFIEDbut from non existingandroid/app/src/main/jnifolder: what should we do? <- it seems we can just ignoreeandroid/settings.gradleadd two lines for hermes in aifblock we don't have but exist in version from and to: what should we do? <- it seems we can just add and it will be ignoredios/Podfileours as many difference than versionfromandto, what should we do? <- it seems we can just take all change:fabric_enabled => flags[:fabric_enabled],<- it seems we can just add ituse_frameworks! enabledit will not work, looking at our repo, I can't find anyuse_frameworks!<- it seems we can just add it# An absolute path to your application root.), with line:app_path => "#{Pod::Config.instance.installation_root}/.."seems to exist in version from, but not in our, what should we do? <- it seems we can just add itmac_catalyst_enabled, we should have a line__apply_Xcode_12_5_M1_post_install_workaroundthat we don't have. <- it seems we can just add itios/RnDiffApp/AppDelegate.mm: we don't have this file, we have ourAppDelegate.mwhich is totally different: what should we do? <- it seems we can just ignoreThis is the analysis we have done to justify those difference:
Our last 2 previous upgrade:
https://react-native-community.github.io/upgrade-helper/?from=0.66.0&to=0.68.2is addingandroid/app/src/main/java/com/rndiffapp/newarchitecture/MainApplicationReactNativeHost.javawith messageThis file is only required for the New Architecture setup.jnifiles are also written experimentalThis is how we are trying so far:
Excluding files that failed to apply the diff:
.gitignore: difficulty easy -> fixed :heavy_check_mark:.ruby-version: difficulty easy -> fixed :heavy_check_mark:Gemfile: difficulty easy -> fixed :heavy_check_mark:android/app/build.gradle: medium -> fixed :warning: <- it seems we don't need to do change if we don't enable new architectureandroid/app/src/main/java/com/passculture/MainActivity.java: difficulty easy -> fixed :heavy_check_mark:android/build.gradle: difficulty easy -> fixed :heavy_check_mark:android/gradle/wrapper/gradle-wrapper.jar: difficulty easy -> fixed :heavy_check_mark:android/settings.gradle: difficulty easy -> fixed :heavy_check_mark:ios/.xcode.env: difficulty easy -> fixed :heavy_check_mark:ios/Podfile: difficulty easy -> fixed :heavy_check_mark:ios/PassCulture.xcodeproj/project.pbxproj: difficulty easy -> fixed :heavy_check_mark:The pull request: https://github.com/pass-culture/pass-culture-app-native/pull/4045
So far, we aren't able to succeed the upgrade build. Where can we find some help and expert? Is this the right place to ask question?
Thank you!