Modal not respecting window flags (FLAG_SECURE) on Android

CaioQuirinoMedeiros commented 1 year ago

Description

I am trying to disable screenshot and screen recording on my application, for security purpose. I've known that it can be done by setting the flags FLAG_SECURE on activity window

It works... screenshots are not allowed and screen recording get all black... exepct the Modal! The Modal is still shown on the screen recording. Why is that? There are any way to fix that? I tried to set the flag for all activities but still no success.

React Native Version

0.72.3

Output of `npx react-native info`

System: OS: macOS 13.0.1 CPU: (8) arm64 Apple M1 Memory: 112.33 MB / 8.00 GB Shell: version: 5.8.1 path: /bin/zsh Binaries: Node: version: 16.14.0 path: ~/.nvm/versions/node/v16.14.0/bin/node Yarn: version: 1.22.19 path: ~/.yarn/bin/yarn npm: version: 8.3.1 path: ~/.nvm/versions/node/v16.14.0/bin/npm Watchman: version: 2022.05.16.00 path: /opt/homebrew/bin/watchman Managers: CocoaPods: version: 1.11.3 path: /usr/local/bin/pod SDKs: iOS SDK: Platforms:

DriverKit 22.1
iOS 16.1
macOS 13.0
tvOS 16.1
watchOS 9.1 Android SDK: Not Found IDEs: Android Studio: 2021.3 AI-213.7172.25.2113.9123335 Xcode: version: 14.1/14B47b path: /usr/bin/xcodebuild Languages: Java: version: 11.0.12 path: /usr/bin/javac Ruby: version: 2.6.10 path: /usr/bin/ruby npmPackages: "@react-native-community/cli": Not Found react: installed: 18.2.0 wanted: 18.2.0 react-native: installed: 0.72.3 wanted: 0.72.3 react-native-macos: Not Found npmGlobalPackages: "react-native": Not Found Android: hermesEnabled: true newArchEnabled: false iOS: hermesEnabled: true newArchEnabled: false

Steps to reproduce

Create a new React Native project
Set the window flags as FLAG_SECURE as described here (remember to build after that)
Start recording and use the App, use a Modal.
Check that the Modal is shown on the recorded video

CaioQuirinoMedeiros commented 1 year ago

https://commonsware.com/blog/2016/06/06/psa-flag-secure-window-leaks.html Found this blog article that explains a lot... can I somehow add flags to the Dialog window used by Modal component? it should be done on ReactModalHostView? I'd have to build RN from source?

dragorwyin commented 11 months ago

Hello, I'm joining with the issue report. The same thing happens for all our modals. Pinging up for the questions from @CaioQuirinoMedeiros

dragorwyin commented 9 months ago

Hello, pinging a request :)

bakhiem commented 8 months ago

Yes, I got the same problem

facebook / react-native