search

facebook / react-native

A framework for building native applications using React
https://reactnative.dev
MIT License
116.27k stars 23.99k forks source link

Simplify timer deletion code #44443

Closed javache closed 1 week ago

javache commented 1 week ago

Summary: Call erase directly instead of doing find + erase.

Changelog: [Internal]

Differential Revision: D57049086

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D57049086

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D57049086

analysis-bot commented 1 week ago
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,495,263 -24
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,867,596 -26
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 06eea61c19cd730cf0c14a436f042d30791c3f4a Branch: main

facebook-github-bot commented 1 week ago

This pull request has been merged in facebook/react-native@29c3bc04441c0d5e18668c7a93f069b3417d5a16.

github-actions[bot] commented 1 week ago

This pull request was successfully merged by @javache in 29c3bc04441c0d5e18668c7a93f069b3417d5a16.

When will my fix make it into a release? | How to file a pick request?