Closed joevilches closed 1 week ago
This pull request was exported from Phabricator. Differential Revision: D54640600
Platform | Engine | Arch | Size (bytes) | Diff |
---|---|---|---|---|
android | hermes | arm64-v8a | 19,495,449 | +67 |
android | hermes | armeabi-v7a | n/a | -- |
android | hermes | x86 | n/a | -- |
android | hermes | x86_64 | n/a | -- |
android | jsc | arm64-v8a | 22,867,642 | +65 |
android | jsc | armeabi-v7a | n/a | -- |
android | jsc | x86 | n/a | -- |
android | jsc | x86_64 | n/a | -- |
Base commit: 958f8e2bb55ba3a2ace9507a48a582f546dd3ec2 Branch: main
This pull request was exported from Phabricator. Differential Revision: D54640600
This pull request has been merged in facebook/react-native@b0e746e4bb3a27d3aee33d9228e62c8d2e336aef.
This pull request was successfully merged by @joevilches in b0e746e4bb3a27d3aee33d9228e62c8d2e336aef.
When will my fix make it into a release? | How to file a pick request?
Summary: This works similar to how
transform
is parsed in that it sets tags on the View to actually update the prop when all the prop setters are done being called since the parsing of the array is not very trivial. Besides that it is pretty simple and just calls intoFilterHelper
and usessetRenderEffect
: https://developer.android.com/reference/android/view/View#setRenderEffect(android.graphics.RenderEffect).That API is only exposed in version 31 of the SDK so it is gated accordingly.
Reviewed By: NickGerleman
Differential Revision: D54640600