facebook / react-native

A framework for building native applications using React
https://reactnative.dev
MIT License
116.27k stars 23.99k forks source link

docs(react-native): fix app build.gradle react config default paths #44472

Closed monholm closed 1 week ago

monholm commented 1 week ago

Summary:

Minor inconvenience I noticed while doing some testing in a mono-repo.

The current paths points to the android folder, but should point to the project root. Currently the android build fails if one uncomments the folder paths as they are.

Changelog:

[ANDROID] [FIXED] - Fix incorrect paths in app build.gradle react config block

Test Plan:

Uncomment the paths are they are and notice the android build error:

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':app'.
> Failed to notify project evaluation listener.
   > /xyz/xyz/xyz/xyz/RNPathTester/android/node_modules/react-native/ReactAndroid/gradle.properties (No such file or directory)

Use the updated paths and notice the build succeeds 🥳

analysis-bot commented 1 week ago
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,495,382 +3
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,867,584 +12
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: deee037c62a7d62a349d34db427b14d3560ddf83 Branch: main

facebook-github-bot commented 1 week ago

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

github-actions[bot] commented 1 week ago

This pull request was successfully merged by @monholm in 2d8c6f591c3c17b75afced101a2f86e773e98a54.

When will my fix make it into a release? | How to file a pick request?