facebook / react-native

A framework for building native applications using React
https://reactnative.dev
MIT License
116.27k stars 23.99k forks source link

Stop emitting deprecated onTextInput events #44479

Closed javache closed 1 week ago

javache commented 1 week ago

Summary: TextInputs' onTextInput callback was removed way back in React Native 0.62 with https://github.com/facebook/react-native/commit/3f7e0a2c9601fc186f25bfd794cd0008ac3983ab , but remnants of the implementation exists.

We first have to remove the event emitting in native code, and can land the full removal separately in D57092733, once there's no older client references remaining to this event.

Changelog: [General][Removed] Remove deprecated onTextInput callback

Reviewed By: cipolleschi

Differential Revision: D57092734

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D57092734

analysis-bot commented 1 week ago
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,495,376 -3
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,867,579 +7
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: deee037c62a7d62a349d34db427b14d3560ddf83 Branch: main

facebook-github-bot commented 1 week ago

This pull request has been merged in facebook/react-native@34a50ae8ef559f309117d5b6abe0b68b2b349fa4.

github-actions[bot] commented 1 week ago

This pull request was successfully merged by @javache in 34a50ae8ef559f309117d5b6abe0b68b2b349fa4.

When will my fix make it into a release? | How to file a pick request?